remove records of deleted pods from failure stores automatically and add an e2e test #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofyc
force-pushed
the
fix2459
branch
3 times, most recently
from
ff6cad4
to
f38ffbb
Compare
|
/run-e2e-tests |
cofyc
requested review from
weekface,
DanielZhangQD and
Yisaer
and removed request for
weekface and
DanielZhangQD
cofyc
changed the title
| @@ -201,6 +201,11 @@ func (tkmm *tikvMemberManager) syncStatefulSetForTidbCluster(tc *v1alpha1.TidbCl | |||
| return err | |||
| } | |||
|
|
|||
| // Recover failed stores if any before generating desired statefulset | |||
There was a problem hiding this comment.
We should also try to recover for TiFlash.
Yisaer
approved these changes
May 26, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb-operator
that referenced
this pull request
May 27, 2020
Signed-off-by: sre-bot <[email protected]>
|
cherry pick to release-1.1 in PR #2565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fixes #2459
fixes #1464
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: